davidxl added inline comments.
================ Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:1781 + // analysis. + if (VTable->isDeclarationForLinker()) + CGM.addCompilerUsedGlobal(VTable); ---------------- Is it better to guard it with with if (CGM.getCodeGenOpts().WholeProgramVTables) which seems clearer in intention? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96919/new/ https://reviews.llvm.org/D96919 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
