HazardyKnusperkeks added a comment. In D95017#2572578 <https://reviews.llvm.org/D95017#2572578>, @PragmaNull wrote:
> In D95017#2572238 <https://reviews.llvm.org/D95017#2572238>, @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order and case-sensitive >> order. > > I'm okay with the names, it just seems to me that they are reversed, where > CaseSensitive should sort using ASCIIbetic order, and CaseInsensitive should > ignore case entirely in the same way that most case-insensitive string > compares would. After initially reading it I was not sure about it, but now I have looked into the wikipedia: > In computers, case sensitivity defines whether uppercase and lowercase > letters are treated as distinct (case-sensitive) or equivalent > (case-insensitive). So I would support a name switch. I would wait a few days for @kentsommer to say something, if he doesn't respond just make a diff and add me as reviewer. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95017/new/ https://reviews.llvm.org/D95017 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
