davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.
lgtm
================
Comment at: lib/CodeGen/CoverageMappingGen.cpp:468
@@ +467,3 @@
+ MostRecentLocation == getEndOfFileOrMacro(MostRecentLocation) &&
+ isRegionAlreadyAdded(getStartOfFileOrMacro(MostRecentLocation),
+ MostRecentLocation))
----------------
Perhaps add a comment here that there is need to create 'outer most' code
region for while/for stmt('s virtual file) with counter equal to the
parent/enclosing scope's counter. The expansion region's counter will be copied
from it during coverage reading. Also refer to handleFileExit where the region
is created.
http://reviews.llvm.org/D19725
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
