rsmith added a comment.

Thanks for the diagnosis and the patch!

We spend a significant amount of our AST file size on these lookup tables, so I 
think the extra two bytes per lookup entry is best avoided if possible. We also 
have the same problem for other on-disk hash tables. I went ahead and 
generalized this to cover all of our on-disk hash tables and switched from 
fixed-width to variable-width encoding in 
rGe0589d70fb8e29842fab228df716f73b378710a6 
<https://reviews.llvm.org/rGe0589d70fb8e29842fab228df716f73b378710a6>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97000/new/

https://reviews.llvm.org/D97000

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D97000: [... Danila Kutenin via Phabricator via cfe-commits
    • [PATCH] D970... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D970... Danila Kutenin via Phabricator via cfe-commits

Reply via email to