dexonsmith added a comment. In D96816#2572552 <https://reviews.llvm.org/D96816#2572552>, @ahatanak wrote:
> I still don't understand why the test was failing, but did we have to bump > the version because a new LangOpt (`EncodeCXXClassTemplateSpec`) was added? Here are the RUN lines: // RUN: mkdir -p %t/mod // RUN: touch %t/empty.h // RUN: cp %S/Inputs/preamble-reparse-changed-module/module.modulemap %t/mod // RUN: cp %S/Inputs/preamble-reparse-changed-module/head.h %t/mod // RUN: env CINDEXTEST_EDITING=1 CINDEXTEST_EXECUTE_COMMAND="cp %S/Inputs/preamble-reparse-changed-module/new-head.h %t/mod/head.h" CINDEXTEST_EXECUTE_AFTER_TRIAL=1 \ // RUN: c-index-test -test-load-source-reparse 3 local %s -I %t -I %t/mod -fmodules -fmodules-cache-path=%t/mcp 2>&1 | FileCheck %s It wouldn't have failed in a clean build. The test is reusing the module cache path `%t/mcp` from the previous run. I think most implicit modules tests make themselves robust to incremental builds by adding something like this before the first use of the cache: // RUN: rm -rf %t/mcp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96816/new/ https://reviews.llvm.org/D96816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
