MaskRay added inline comments.
================ Comment at: clang/test/Driver/debug-options-as.c:65 +// Check that -gdwarf-N can be placed before other options of the "-g" group. +// RUN: %clang -### -c -g -gdwarf-3 -integrated-as -x assembler %s 2>&1 \ +// RUN: | FileCheck -check-prefix=DWARF3 %s ---------------- ikudrin wrote: > MaskRay wrote: > > Nit: use the more common spelling `-fintegrated-as` > > > > `-triple %itanium_abi_triple` > > > > msvc windows triples ideally don't need `-dwarf-version=`, but that can be > > a separate clean-up. > > Nit: use the more common spelling -fintegrated-as > `-integrated-as` is what other tests in this file use. Is it OK if these > lines will not follow the common template? > I think it should be fine... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96865/new/ https://reviews.llvm.org/D96865 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
