amyk accepted this revision as: amyk. amyk added a comment. This revision is now accepted and ready to land.
I just have a small question about the patch but overall I think this LGTM. ================ Comment at: llvm/lib/Target/PowerPC/PPC.td:317 // Power8 list<SubtargetFeature> P8AdditionalFeatures = [DirectivePwr8, ---------------- Does `FeatureROPProtection` need to be here and in the P9/P10 features? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96512/new/ https://reviews.llvm.org/D96512 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits