aaron.ballman added a comment. In D94621#2554228 <https://reviews.llvm.org/D94621#2554228>, @segoon wrote:
> alexfh, aaron.ballman, hi! Any comments on the patch? Have you run this check over large real-world code bases beyond Yandex.Taxi? I think this is likely to be a maintenance burden because the list of blocking functions will likely never be complete (e.g., it's missing all the Win32 functions and `wchar_t` variants from C and POSIX) and I'm concerned that the output will be too chatty to be useful except in projects that are laid out in a very particular way. I would anticipate that these functions get used within a concurrent thread with some frequency specifically *because* they're blocking operations (so they are performed in a thread to keep the main thread unblocked). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94621/new/ https://reviews.llvm.org/D94621 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
