sammccall added inline comments.
================ Comment at: clang/test/CodeCompletion/member-access.cpp:88 + TemplateClass<S, T> &relatedField; + BaseTemplate<S> &relatedFunction(); + ---------------- hokein wrote: > hmm, inserting new code here will shift all offsets of below code, I would > append a new test in this file to keep a clearer history. but up to you. I see your point about history, but I find myself navigating these tests by semantics more often than by history, and this seems closely related to the existing completeDependentMembers cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96376/new/ https://reviews.llvm.org/D96376 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
