vsavchenko added a comment.

Great job!
I'd like to see more tests with the following cases:

- more expressions with function calls - ternary expression, arithmetic, array 
literals, initializer lists, etc.
- using/not using it in `if` statement with initializer
- using/not using it in different parts of GNU statement expressions
- calls in different parts of exception handling (both C++ and Obj-C)
- calls in lambdas/blocks/coroutines
- calls in different parts of C++ range-for loop
- calls in different parts of Obj-C for loop over collections
- calls under labels
- calls in attributed statements (e.g. `[[clang::nomerge]] foo()`)
- calls in goto statements
- calls in Obj-C `@synchronized` and `@autoreleasepool` statements


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D90691/new/

https://reviews.llvm.org/D90691

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to