fhahn added inline comments.
================
Comment at: clang/include/clang/Basic/CodeGenOptions.h:147
+ No = 2, // No loop is assumed to be finite.
+ };
+
----------------
jdoerfert wrote:
> Can we have different names?
>
> `FiniteLoopsKind::None` sounds more like what ``FiniteLoopsKind::No` implies.
>
> Maybe:
> ```
> enum class FiniteLoopAssumptionKind {
> LANGUAGE,
> ALWAYS
> NEVER,
> };
> ```
Updated the names, thanks! They are much better.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96419/new/
https://reviews.llvm.org/D96419
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
