JonChesterfield accepted this revision.
JonChesterfield added a comment.

This works around the limitations of the binary format nvptx and amdgpu are 
using in the compiler. It's the wrong place in the stack to fix it - we could 
introduce another symbol table in the binary to capture the per-tu-between-arch 
scoping.

However, if we later reach consensus on what to do in the elf instead, we can 
still do that. In particular, embedding an elf for one arch in a named section 
of an elf for a host arch is crude. This workaround seems acceptable in the 
meantime.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85223/new/

https://reviews.llvm.org/D85223

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to