tianshilei1992 requested changes to this revision. tianshilei1992 added a comment. This revision now requires changes to proceed.
In D96248#2551503 <https://reviews.llvm.org/D96248#2551503>, @JonChesterfield wrote: > @tianshilei1992 @jdoerfert can we agree on 'libomptarget-device-bc-path' > being the better one to recommend in the error message, despite that being a > minor change to the current behaviour? It'll slightly surprise people parsing > error messages, such as our test, but shouldn't cause any confusion. After a second thought, I don't think it is feasible. Consider the following senecio: clang -fopenmp -fopenmp-targets=nvptx64,amdgcn source.cpp We cannot use one option for the two different targets, and the alias might not work as well, especially in terms of the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96248/new/ https://reviews.llvm.org/D96248 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
