[PATCH] D92808: [ObjC][ARC] Use operand bundle 'clang.arc.rv' instead of explicitly emitting retainRV or claimRV calls in the IR

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Here's a reduced repro:

  thakis@thakis:~/src/llvm-project$ cat 
GREYAssertDefaultConfiguration-9e1f3b.reduced.m
  inline id a() {}
  void b() {
    a();
    a();
  }
  thakis@thakis:~/src/llvm-project$ out/gn/bin/clang -cc1 -cc1 -triple 
arm64-apple-ios12.2.0 -Oz -fobjc-arc -emit-llvm 
GREYAssertDefaultConfiguration-9e1f3b.reduced.m
  GREYAssertDefaultConfiguration-9e1f3b.reduced.m:1:16: warning: non-void 
function does not return a value [-Wreturn-type]
  inline id a() {}
                 ^
  clang: ../../llvm/include/llvm/IR/InstrTypes.h:1969: 
Optional<llvm::OperandBundleUse> llvm::CallBase::getOperandBundle(uint32_t) 
const: Assertion `countOperandBundlesOfType(ID) < 2 && "Precondition 
violated!"' failed.
  PLEASE submit a bug report to https://bugs.llvm.org/ and include the crash 
backtrace, preprocessed source, and associated run script.
  Stack dump:
  0.    Program arguments: out/gn/bin/clang -cc1 -cc1 -triple 
arm64-apple-ios12.2.0 -Oz -fobjc-arc -emit-llvm 
GREYAssertDefaultConfiguration-9e1f3b.reduced.m
  1.    <eof> parser at end of file
  2.    Per-module optimization passes
  3.    Running pass 'CallGraph Pass Manager' on module 
'GREYAssertDefaultConfiguration-9e1f3b.reduced.m'.
   #0 0x00000000034a054c llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/lib/Support/Unix/Signals.inc:565:13
   #1 0x000000000349e45e llvm::sys::RunSignalHandlers() 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/lib/Support/Signals.cpp:72:18
   #2 0x00000000034a089f SignalHandler(int) 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/lib/Support/Unix/Signals.inc:407:1
   #3 0x00007f8505e34140 __restore_rt 
(/lib/x86_64-linux-gnu/libpthread.so.0+0x14140)
   #4 0x00007f850594cce1 raise ./signal/../sysdeps/unix/sysv/linux/raise.c:51:1
   #5 0x00007f8505936537 abort ./stdlib/abort.c:81:7
   #6 0x00007f850593640f get_sysdep_segment_value ./intl/loadmsgcat.c:509:8
   #7 0x00007f850593640f _nl_load_domain ./intl/loadmsgcat.c:970:34
   #8 0x00007f8505945662 (/lib/x86_64-linux-gnu/libc.so.6+0x34662)
   #9 0x0000000002be88bd (out/gn/bin/clang+0x2be88bd)
  #10 0x0000000003afdd35 hasValue 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/include/llvm/ADT/Optional.h:194:53
  #11 0x0000000003afdd35 hasValue 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/include/llvm/ADT/Optional.h:286:52
  #12 0x0000000003afdd35 hasRVOpBundle 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/include/llvm/Analysis/ObjCARCUtil.h:42:61
  #13 0x0000000003afdd35 llvm::InlineFunction(llvm::CallBase&, 
llvm::InlineFunctionInfo&, llvm::AAResults*, bool, llvm::Function*) 
/usr/local/google/home/thakis/src/llvm-project/out/gn/../../llvm/lib/Transforms/Utils/InlineFunction.cpp:1953:9

Given that the repro is so tiny, I've reverted this for now in 
de1966e5427985163f8e816834b3a0564b5e24cd 
<https://reviews.llvm.org/rGde1966e5427985163f8e816834b3a0564b5e24cd>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92808/new/

https://reviews.llvm.org/D92808

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits