jdoerfert added a comment.
In D91054#2548266 <https://reviews.llvm.org/D91054#2548266>, @AMDChirag wrote:
> @fghanim @jdoerfert please review the code if/when possible.
Let's resolve the issue described in the TODO before we go ahead with this.
There is little point reviewing something that can't be tested.
That said,
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:3579
+ SectionCBVector.push_back(SectionCB);
+ }
+ } else {
----------------
Why do we unpack the children here instead of making a single call back for the
CapturedStmt?
================
Comment at: clang/test/OpenMP/cancel_sections_irbuilder.cpp:14
+// which in turn causes FiniCB callback to fail in FinalizeOMPRegion()
+// as no terminator instruction (br) exists for the cancel block (<xyz>.cncl)
+
----------------
I don't get it. Where is EmitOMPRegionBody called on the `<xyz>.cncl` block
such that it would remove the terminator?
Maybe you could share the IR at the different levels if you need help resolving
the problem.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D91054/new/
https://reviews.llvm.org/D91054
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
