balazske added inline comments. Herald added a subscriber: nullptr.cpp.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone-signal-handler-posix.c:4 +// RUN: [{key: bugprone-signal-handler.AsyncSafeFunctionSet, value: "POSIX"}]}' \ +// RUN: -- -isystem %S/Inputs/Headers + ---------------- aaron.ballman wrote: > I'd like to make sure we have a test for this that explicitly runs on Windows. If an extra test file only for windows, can you tell what additionally to test for in that file? I think the current tests run an all platforms, to add a new test there should be additional cases that are Windows-specific. The header files should come only from the test directory (same for all platforms), not from the real system includes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90851/new/ https://reviews.llvm.org/D90851 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits