RedDocMD marked an inline comment as done.
RedDocMD added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/BasicValueFactory.cpp:180
+bool noRepeatedElements(
+ const llvm::ImmutableList<const CXXBaseSpecifier *> &BaseSpecList) {
----------------
vsavchenko wrote:
> nit: functions represent actions, in languages verbs act the same way, so
> it's recommended to use verbs in functions (`hasNoRepeatedElements`)
>
> + `LLVM_MAYBE_UNUSED` because in the build without assertions it would be a
> warning otherwise.
> nit: functions represent actions, in languages verbs act the same way, so
> it's recommended to use verbs in functions (`hasNoRepeatedElements`)
>
> + `LLVM_MAYBE_UNUSED` because in the build without assertions it would be a
> warning otherwise.
How do I put in the LLVM_MAYBE_UNUSED? Sorry for being annoying, but
ripgrepping or Googling didn't return anything.
================
Comment at: clang/test/Analysis/pointer-to-member.cpp:314-333
+// namespace testReinterpretCasting {
+// struct Base {
+// int field;
+// };
+//
+// struct Derived : public Base {};
+//
----------------
vsavchenko wrote:
> Uncomment it, and expect the actual current result. This is where `TODO`
> will come in handy.
> Uncomment it, and expect the actual current result. This is where `TODO`
> will come in handy.
Will do it.
Just one clarification: the static analyzer tests only serve to check whether
the Static Analyzer crashes or hits an assertion error, or is it something more?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95877/new/
https://reviews.llvm.org/D95877
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
