vsavchenko added a comment. Herald added a subscriber: nullptr.cpp. In D92639#2505163 <https://reviews.llvm.org/D92639#2505163>, @ASDenysPetrov wrote:
> @vsavchenko > >> F14534708: report-6ea17d.html <https://reviews.llvm.org/F14534708> > > I checked it in IE. It doesn't draw arrows. Investigate this, please. Oh, I checked it (using a bunch of weird websites to host html and then to see it in IE). It doesn't show it and I have no idea why. I don't have easy access to IE and I couldn't fix it unfortunately :-( If you know any good way I can run it on Mac, I'd be happy to test it. ================ Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:147 +bool isArrowPiece(const PathDiagnosticPiece &P) { + return isa<PathDiagnosticControlFlowPiece>(P) && P.getString().empty(); +} ---------------- ASDenysPetrov wrote: > Are you sure that **non-arrow** piece **always** has **non-empty** string > representation? Can this give us a false positive result? I haven't seen empty grey bubbles. If there are pieces like this, it'd be a bug in event generation. ================ Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:458 } if (event.key == "S") { var checked = document.getElementsByName("showCounterexample")[0].checked; ---------------- ASDenysPetrov wrote: > Seems like this shortcut works only with the capital **S** aka //shift+s// > Should we support any **s** state? As far as I understand, that matches the original intention because the help message mentions exactly "Shift+S" {F15355624} Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92639/new/ https://reviews.llvm.org/D92639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
