nridge added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:264
+ $Class[[D]] $Field_decl[[E]];
+ static double $StaticField_decl_static[[S]];
+ static void $StaticMethod_decl_static[[bar]]() {}
----------------
sammccall wrote:
> nridge wrote:
> > Presumably, the highlighting kinds `StaticField` and `StaticMethod` are
> > going to be collapsed into `Field` and `Method` in a future change (after
> > the removal of TheiaSemanticHighlighting, I guess)?
> Yeah, merging any kinds that are exported with the same name should be NFC at
> that point.
>
> Hmm, though currently StaticField --> Variable, not Field (similarly
> StaticMethod --> Method).
> So we can have static fields be Variable+Static+ClassScope or
> Field+Static+ClassScope.
>
> I can see arguments for either...
I don't have a strong opinion on this one.
Maybe Field+Static+ClassScope, that way clients that use a generic theme (and
thus do not recognize ClassScope) will color it as Field rather than Variable?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77811/new/
https://reviews.llvm.org/D77811
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
