dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land.
Sounds alright to me. (non-action idle thoughts: Might be worth revisiting this documentation to make it a bit more direct/clearer that many of these optimizations (at least the vtable and ctor homing) rely on the assumption that the class is instantiated somewhere in the program (and that somewhere is built with debug info enabled) (the wording you've got here "This relies on the additional assumption that all classes that are not trivially constructible have a non-trivial constructor that is used somewhere." but maybe generalized/massaged a bit)) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95911/new/ https://reviews.llvm.org/D95911 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
