rjmccall added a comment. Thanks, LGTM with the value-kind fix.
================ Comment at: clang/lib/Sema/SemaInit.cpp:4308 + if (T1Quals.hasAddressSpace()) + Sequence.AddQualificationConversionStep(cv1T1, VK_XValue); + } else ---------------- Anastasia wrote: > rjmccall wrote: > > This should only be `VK_XValue` if we're binding a r-value reference, I > > think. > Yes, I think so too. Did you mean to fix this to conditionally use VK_LValue? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95608/new/ https://reviews.llvm.org/D95608 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
