sammccall added a comment.

This looks about right to me...
Unfortunately I landed ff4832dbff0ccf1fd29f726efe72fd1220cd645a 
<https://reviews.llvm.org/rGff4832dbff0ccf1fd29f726efe72fd1220cd645a> and 
1eb7fd089e2fcf3fe211f865b28e2fed12128c3f 
<https://reviews.llvm.org/rG1eb7fd089e2fcf3fe211f865b28e2fed12128c3f> meanwhile 
so this will need a rebase :-(

The first of those patches introduces flags on returned refs to indicate which 
are decls/defs. I'd suggest adding an "override" flag and populating it for 
these results.
Hopefully we'll have a sensible way to expose these flags over LSP someday, 
meanwhile I think our internal embedders may like to surface that.

(I guess the bug includes the other side of this, where if the method is an 
override, calls to base methods are reported. Makes sense to split it into a 
separate patch...)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95812/new/

https://reviews.llvm.org/D95812

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to