aaron.ballman added a comment.

Thank you for working on this, I think it's fantastic effort!

> I'll make sure to implement (and hopefully test) a reasonable behavior for 
> all various combinations of CMake flags (eg., clang-tidy enabled/disabled, 
> static analyzer enabled/disabled, static-analyzer-into-clang-tidy integration 
> enabled/disabled, etc.).

Will we be able to stand up a buildbot to explicitly test this configuration?

> This patch introduces a frontend flag -analyzer-tidy-checker=...

FWIW, the usual clang-tidy nomenclature is to call these "checks" rather than 
"checkers", so it might make sense to expose `-analyzer-tidy-checks=...` to be 
analogous to `clang-tidy -checks=...`

> As long as at least one such flag is supplied, ClangTidyContext is 
> instantiated with the given checker list and a clang-tidy AST consumer gets 
> multiplexed with AnalysisConsumer so that to run clang-tidy checkers.

clang-tidy currently runs the clang static analyzer, so I worry a little bit 
about duplicated diagnostics. I assume that we'll disable running the static 
analyzer checks a second time through clang-tidy?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95403/new/

https://reviews.llvm.org/D95403

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to