Author: Sam McCall Date: 2021-01-31T12:13:20+01:00 New Revision: 60053a9ce28655fc6f635567c62599fa3aad57d2
URL: https://github.com/llvm/llvm-project/commit/60053a9ce28655fc6f635567c62599fa3aad57d2 DIFF: https://github.com/llvm/llvm-project/commit/60053a9ce28655fc6f635567c62599fa3aad57d2.diff LOG: [clangd] Remove references to old future-based API. NFC Added: Modified: clang-tools-extra/clangd/ClangdServer.h clang-tools-extra/clangd/support/Context.h Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/ClangdServer.h b/clang-tools-extra/clangd/ClangdServer.h index 0a452daa79ed..fd5a4bf9a40d 100644 --- a/clang-tools-extra/clangd/ClangdServer.h +++ b/clang-tools-extra/clangd/ClangdServer.h @@ -34,7 +34,6 @@ #include "llvm/ADT/Optional.h" #include "llvm/ADT/StringRef.h" #include <functional> -#include <future> #include <string> #include <type_traits> #include <utility> @@ -194,13 +193,8 @@ class ClangdServer { void removeDocument(PathRef File); /// Run code completion for \p File at \p Pos. - /// Request is processed asynchronously. /// - /// This method should only be called for currently tracked files. However, it - /// is safe to call removeDocument for \p File after this method returns, even - /// while returned future is not yet ready. - /// A version of `codeComplete` that runs \p Callback on the processing thread - /// when codeComplete results become available. + /// This method should only be called for currently tracked files. void codeComplete(PathRef File, Position Pos, const clangd::CodeCompleteOptions &Opts, Callback<CodeCompleteResult> CB); diff --git a/clang-tools-extra/clangd/support/Context.h b/clang-tools-extra/clangd/support/Context.h index 894032bdd883..815962b523d6 100644 --- a/clang-tools-extra/clangd/support/Context.h +++ b/clang-tools-extra/clangd/support/Context.h @@ -82,8 +82,6 @@ class Context { public: /// Same as Context::empty(), please use Context::empty() instead. - /// Constructor is defined to workaround a bug in MSVC's version of STL. - /// (arguments of std::future<> must be default-constructible in MSVC). Context() = default; /// Copy operations for this class are deleted, use an explicit clone() method _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
