sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clangd/Protocol.cpp:837
return false;
+ tryMap(Params, "triggerCharacter", R.triggerCharacter, P);
R.triggerKind = static_cast<CompletionTriggerKind>(TriggerKind);
----------------
why are we no longer checking the value?
================
Comment at: clang-tools-extra/clangd/Protocol.cpp:33
+template <typename T>
+bool mapOptionalOrLog(llvm::json::ObjectMapper &O, llvm::StringLiteral Prop,
+ T &Out) {
----------------
sammccall wrote:
> I would call this tryMap for brevity
Sorry... now that it can fail, I don't think `tryMap` is a great name anymore.
`mapOptOrNull`? `mapNullable`?
up to you
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D95229/new/
https://reviews.llvm.org/D95229
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
