dexonsmith added a comment.
It would be great if you could split the `--` support out into a separate patch
to commit ahead of time, but I left a couple of comments since I was taking a
look.
================
Comment at: clang/lib/Tooling/Tooling.cpp:438-440
for (StringRef Arg : Args)
if (Arg.startswith("-resource-dir"))
return;
----------------
Seems like this should break early on `--`. You could also avoid the subsequent
`llvm::find` by remembering where it is.
================
Comment at: clang/test/ClangScanDeps/Inputs/static-analyzer-cdb.json:4-5
"directory": "DIR",
- "command": "clang --analyze DIR/static-analyzer.c",
- "file": "DIR/static-analyzer.c"
+ "command": "clang --analyze -- DIR/static-analyzer_clang.c",
+ "file": "DIR/static-analyzer_clang.c"
+},
----------------
It's not clear why you made these changes. Can you clarify?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92191/new/
https://reviews.llvm.org/D92191
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
