mkazantsev added inline comments.
================
Comment at: llvm/lib/Transforms/Scalar/SimplifyCFGPass.cpp:263
const SimplifyCFGOptions &Options) {
- assert((!RequireAndPreserveDomTree ||
- (DT && DT->verify(DominatorTree::VerificationLevel::Full))) &&
----------------
lebedev.ri wrote:
> mkazantsev wrote:
> > Why remove that? It looks useful to have (maybe over-paranoid) checks that
> > DT is correct at least for the first time. I'd rather keep them for a while
> > unless there is a reason to drop them now.
> Note that this checks that the DomTree *provided by the pass manager* is
> valid.
> Do we actually want to check that here?
This assert is meant to check that we actually pass it a DomTree immediately
from the pass manager, and not some previously modified dom tree. It's up to
you, but I'm a little bit paranoid when it comes to validation of analysis
structures. It's never too late to remove redundant assertions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94827/new/
https://reviews.llvm.org/D94827
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
