curdeius accepted this revision. curdeius added a comment. LGTM. As a note, I agree with @MyDeveloperDay. It's more user-friendly and IMO less surprising to set the base wrapping style in `BreakBeforeBraces` and then customize it changing in `BraceWrapping`. I'd argue that it won't be a breaking change for .clang-format configs that are "correct" and would just make the examples you brought above work as intended. Current behaviour is even strange in one case, what values are set to elements *omitted* in `BraceWrapping` when `BreakBeforeBraces` is `Custom`? Those from `LLVM` style? Anyway, that goes way beyond this patch. I'd think about implementing this time permitting.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94906/new/ https://reviews.llvm.org/D94906 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
