balazske updated this revision to Diff 317278. balazske added a comment. Improved test.
Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94786/new/ https://reviews.llvm.org/D94786 Files: clang/lib/AST/ASTImporter.cpp clang/unittests/AST/ASTImporterTest.cpp Index: clang/unittests/AST/ASTImporterTest.cpp =================================================================== --- clang/unittests/AST/ASTImporterTest.cpp +++ clang/unittests/AST/ASTImporterTest.cpp @@ -639,6 +639,38 @@ hasUnqualifiedDesugaredType(constantArrayType(hasSize(7)))))))))); } +const internal::VariadicDynCastAllOfMatcher<Stmt, CXXFoldExpr> cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +} +AST_MATCHER(CXXFoldExpr, hasInit) { return Node.getInit(); } +AST_MATCHER(CXXFoldExpr, isRightFold) { return Node.isRightFold(); } +AST_MATCHER(CXXFoldExpr, isLeftFold) { return Node.isLeftFold(); } + +TEST_P(ImportExpr, ImportCXXFoldExpr) { + auto Match1 = + cxxFoldExpr(hasOperator(BO_Add), isLeftFold(), unless(hasInit())); + auto Match2 = cxxFoldExpr(hasOperator(BO_Sub), isLeftFold(), hasInit()); + auto Match3 = + cxxFoldExpr(hasOperator(BO_Mul), isRightFold(), unless(hasInit())); + auto Match4 = cxxFoldExpr(hasOperator(BO_Div), isRightFold(), hasInit()); + + MatchVerifier<Decl> Verifier; + testImport("template <typename... Ts>" + "void declToImport(Ts... args) {" + " const int i1 = (... + args);" + " const int i2 = (1 - ... - args);" + " const int i3 = (args * ...);" + " const int i4 = (args / ... / 1);" + "};" + "void g() { declToImport(1, 2, 3, 4, 5); }", + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(Match1), hasDescendant(Match2), + hasDescendant(Match3), + hasDescendant(Match4))); +} + /// \brief Matches __builtin_types_compatible_p: /// GNU extension to check equivalent types /// Given Index: clang/lib/AST/ASTImporter.cpp =================================================================== --- clang/lib/AST/ASTImporter.cpp +++ clang/lib/AST/ASTImporter.cpp @@ -644,6 +644,7 @@ ExpectedStmt VisitSubstNonTypeTemplateParmExpr(SubstNonTypeTemplateParmExpr *E); ExpectedStmt VisitTypeTraitExpr(TypeTraitExpr *E); ExpectedStmt VisitCXXTypeidExpr(CXXTypeidExpr *E); + ExpectedStmt VisitCXXFoldExpr(CXXFoldExpr *E); template<typename IIter, typename OIter> Error ImportArrayChecked(IIter Ibegin, IIter Iend, OIter Obegin) { @@ -8011,6 +8012,25 @@ *ToTypeOrErr, *ToExprOperandOrErr, *ToSourceRangeOrErr); } +ExpectedStmt ASTNodeImporter::VisitCXXFoldExpr(CXXFoldExpr *E) { + Error Err = Error::success(); + + auto ToType = importChecked(Err, E->getType()); + auto ToCallee = importChecked(Err, E->getCallee()); + auto ToLParenLoc = importChecked(Err, E->getLParenLoc()); + auto ToLHS = importChecked(Err, E->getLHS()); + auto ToEllipsisLoc = importChecked(Err, E->getEllipsisLoc()); + auto ToRHS = importChecked(Err, E->getRHS()); + auto ToRParenLoc = importChecked(Err, E->getRParenLoc()); + + if (Err) + return std::move(Err); + + return new (Importer.getToContext()) + CXXFoldExpr(ToType, ToCallee, ToLParenLoc, ToLHS, E->getOperator(), + ToEllipsisLoc, ToRHS, ToRParenLoc, E->getNumExpansions()); +} + Error ASTNodeImporter::ImportOverriddenMethods(CXXMethodDecl *ToMethod, CXXMethodDecl *FromMethod) { Error ImportErrors = Error::success();
Index: clang/unittests/AST/ASTImporterTest.cpp =================================================================== --- clang/unittests/AST/ASTImporterTest.cpp +++ clang/unittests/AST/ASTImporterTest.cpp @@ -639,6 +639,38 @@ hasUnqualifiedDesugaredType(constantArrayType(hasSize(7)))))))))); } +const internal::VariadicDynCastAllOfMatcher<Stmt, CXXFoldExpr> cxxFoldExpr; + +AST_MATCHER_P(CXXFoldExpr, hasOperator, BinaryOperatorKind, Op) { + return Node.getOperator() == Op; +} +AST_MATCHER(CXXFoldExpr, hasInit) { return Node.getInit(); } +AST_MATCHER(CXXFoldExpr, isRightFold) { return Node.isRightFold(); } +AST_MATCHER(CXXFoldExpr, isLeftFold) { return Node.isLeftFold(); } + +TEST_P(ImportExpr, ImportCXXFoldExpr) { + auto Match1 = + cxxFoldExpr(hasOperator(BO_Add), isLeftFold(), unless(hasInit())); + auto Match2 = cxxFoldExpr(hasOperator(BO_Sub), isLeftFold(), hasInit()); + auto Match3 = + cxxFoldExpr(hasOperator(BO_Mul), isRightFold(), unless(hasInit())); + auto Match4 = cxxFoldExpr(hasOperator(BO_Div), isRightFold(), hasInit()); + + MatchVerifier<Decl> Verifier; + testImport("template <typename... Ts>" + "void declToImport(Ts... args) {" + " const int i1 = (... + args);" + " const int i2 = (1 - ... - args);" + " const int i3 = (args * ...);" + " const int i4 = (args / ... / 1);" + "};" + "void g() { declToImport(1, 2, 3, 4, 5); }", + Lang_CXX17, "", Lang_CXX17, Verifier, + functionTemplateDecl(hasDescendant(Match1), hasDescendant(Match2), + hasDescendant(Match3), + hasDescendant(Match4))); +} + /// \brief Matches __builtin_types_compatible_p: /// GNU extension to check equivalent types /// Given Index: clang/lib/AST/ASTImporter.cpp =================================================================== --- clang/lib/AST/ASTImporter.cpp +++ clang/lib/AST/ASTImporter.cpp @@ -644,6 +644,7 @@ ExpectedStmt VisitSubstNonTypeTemplateParmExpr(SubstNonTypeTemplateParmExpr *E); ExpectedStmt VisitTypeTraitExpr(TypeTraitExpr *E); ExpectedStmt VisitCXXTypeidExpr(CXXTypeidExpr *E); + ExpectedStmt VisitCXXFoldExpr(CXXFoldExpr *E); template<typename IIter, typename OIter> Error ImportArrayChecked(IIter Ibegin, IIter Iend, OIter Obegin) { @@ -8011,6 +8012,25 @@ *ToTypeOrErr, *ToExprOperandOrErr, *ToSourceRangeOrErr); } +ExpectedStmt ASTNodeImporter::VisitCXXFoldExpr(CXXFoldExpr *E) { + Error Err = Error::success(); + + auto ToType = importChecked(Err, E->getType()); + auto ToCallee = importChecked(Err, E->getCallee()); + auto ToLParenLoc = importChecked(Err, E->getLParenLoc()); + auto ToLHS = importChecked(Err, E->getLHS()); + auto ToEllipsisLoc = importChecked(Err, E->getEllipsisLoc()); + auto ToRHS = importChecked(Err, E->getRHS()); + auto ToRParenLoc = importChecked(Err, E->getRParenLoc()); + + if (Err) + return std::move(Err); + + return new (Importer.getToContext()) + CXXFoldExpr(ToType, ToCallee, ToLParenLoc, ToLHS, E->getOperator(), + ToEllipsisLoc, ToRHS, ToRParenLoc, E->getNumExpansions()); +} + Error ASTNodeImporter::ImportOverriddenMethods(CXXMethodDecl *ToMethod, CXXMethodDecl *FromMethod) { Error ImportErrors = Error::success();
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits