dexonsmith added a comment.

> This patch also refactors OverlayFileSystem's directory iterator 
> implementation (OverlayFSDirIterImpl) and VFSFromYamlDirIterImpl into a 
> single implementation, addressing a FIXME about their conceptual similarity.

Can the `OverlayFSDirIterImpl` part be split into a separate prep commit 
(possibly even NFC) in order to clarify the functional changes here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94844/new/

https://reviews.llvm.org/D94844

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to