kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks for the fix, a small comment about testing though.
================
Comment at: clang-tools-extra/clangd/unittests/FindSymbolsTests.cpp:532
TEST(DocumentSymbols, InHeaderFile) {
TestTU TU;
----------------
we already have a test case for this but it was passing erroneously, as the
include was part of the preamble and never subject to documentoutline traversal.
can you rather update this test to look like:
```
int DeclarationToFinishPreamble;
#inclube "bar.h"
int test() {}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94753/new/
https://reviews.llvm.org/D94753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
