vsavchenko added inline comments.
================ Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:186 - /// Determine the original source location in the original TU for an - /// imported source location. + /// Returns the MacroExpansionContext for the imported TU to which the given + /// corresponds. ---------------- I think it's missing "location" here ================ Comment at: clang/include/clang/CrossTU/CrossTranslationUnit.h:189-190 /// \p ToLoc Source location in the imported-to AST. - /// \return Source location in the imported-from AST and the corresponding - /// ASTUnit object (the AST was loaded from a file using an internal ASTUnit - /// object that is returned here). - /// If any error happens (ToLoc is a non-imported source location) empty is + /// If any error happens (\p ToLoc is a non-imported source location or macro + /// expansion tracking for imported TUs are not implemented yet) empty is /// returned. ---------------- I don't think that this piece of information should be here, it took me a bit to get it. Maybe it can be a separate \note? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94673/new/ https://reviews.llvm.org/D94673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
