HazardyKnusperkeks added a comment. Apart from that last naming issue looks good to me.
================ Comment at: clang/lib/Format/Format.cpp:235 + IO.enumCase(Value, "Never", FormatStyle::ELBAMS_Never); + IO.enumCase(Value, "DontModify", FormatStyle::ELBAMS_DontModify); + IO.enumCase(Value, "LogicalBlock", FormatStyle::ELBAMS_LogicalBlock); ---------------- MyDeveloperDay wrote: > Other places use `Leave` I assume that means the same as DontModify? If that's the case, we should stick with it. Although I personally find DontModify better. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93846/new/ https://reviews.llvm.org/D93846 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
