dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land.
LGTM, with one nit. It'd be nice to add more detail to the commit message as well. ================ Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1146 - Opts.SSPBufferSize = - getLastArgIntValue(Args, OPT_stack_protector_buffer_size, 8, Diags); - ---------------- jansvoboda11 wrote: > This piece of code should've been removed in D84669 which added marshalling > info to `stack_protector_buffer_size`. In that case please commit this separately. Since I presume it's NFC and pretty straightforward, likely you don't need a separate review, but please make sure the commit message is good / refers to what made it NFC / etc.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94488/new/ https://reviews.llvm.org/D94488 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
