xazax.hun added inline comments.
================
Comment at:
clang/include/clang/Analysis/PathDiagnosticConverterDiagnosticConsumer.h:38
+
+ std::map<PathDiagnosticConsumer *, std::unique_ptr<PathDiagnostic>>
+ PartialPDs;
----------------
A pointer pair might be small enough for a DenseMap?
================
Comment at: clang/lib/Analysis/PathDiagnosticConverterDiagnosticConsumer.cpp:20
+void PathDiagnosticConverterDiagnosticConsumer::flushPartialDiagnostic() {
+ if (PartialPDs.empty())
+ return;
----------------
Do we need this early return? We might get the same behavior by simply omitting
this check. I have no strong preference about keeping or removing it.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94476/new/
https://reviews.llvm.org/D94476
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
