lebedev.ri added a comment. Ping
In D93822#2474475 <https://reviews.llvm.org/D93822#2474475>, @dblaikie wrote: > In D93822#2474355 <https://reviews.llvm.org/D93822#2474355>, @lebedev.ri > wrote: > >> Thank you for taking a look! >> >> In D93822#2474236 <https://reviews.llvm.org/D93822#2474236>, @dblaikie wrote: >> >>> I would guess it doesn't meet the on-by-default bar we would prefer for >>> Clang, >> >> Yeah, based on my initial observations, it's pretty chatty. >> >>> but might still be OK. >> >> I'm open to input here, but it would be good to have this at least in >> `-Wextra` (`-Weverything` always being a last resort option). > > Yeah, not sure how @rsmith, @rtrieu, or @aaron.ballman feel about what the > bar for warnings is these days - used to be a bit more hardcore about the "if > it can't be on by default it shouldn't be in clang" than we are these days, I > think. I'd guess -Wextra might be suitable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93822/new/ https://reviews.llvm.org/D93822 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
