balazske added inline comments.

================
Comment at: clang/lib/AST/ASTImporter.cpp:2901
+          // Skip the declaration if injected type is already set.
+          if (isa<InjectedClassNameType>(RI->getTypeForDecl()))
+            continue;
----------------
shafik wrote:
> Is this to fix the bug or is this for efficiency sake?
This is not needed for the fix, it was used in the first version of the fix 
(still only for efficiency). In the current form this looks like unrelated 
change (the old fix included other code at the same location) so I am not 
against removing this part (but add it in a separate change).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94067/new/

https://reviews.llvm.org/D94067

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to