erichkeane added inline comments.

================
Comment at: clang/include/clang/AST/TypeLoc.h:1756
+
+class VectorTypeLoc : public ConcreteTypeLoc<UnqualTypeLoc, VectorTypeLoc,
+                                             VectorType, VectorTypeLocInfo> {
----------------
fhahn wrote:
> Can we reuse/unify this with `MatrixTypeLoc`? And then have `MatrixTypeLoc` 
> just deal with the row/column operands.
Since these have to be ConcreteTypeLocs, I don't think the matrix type can 
directly inherit from it, but it can do something very similar.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93483/new/

https://reviews.llvm.org/D93483

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to