This revision was automatically updated to reflect the committed changes.
Closed by commit rG02eb8e20b51b: Inform the consumer on invalid template
instantiations. (authored by v.g.vassilev).
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92248/new/
https://reviews.llvm.org/D92248
Files:
clang/lib/Sema/SemaTemplateInstantiate.cpp
Index: clang/lib/Sema/SemaTemplateInstantiate.cpp
===================================================================
--- clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -2846,8 +2846,6 @@
SavedContext.pop();
if (!Instantiation->isInvalidDecl()) {
- Consumer.HandleTagDeclDefinition(Instantiation);
-
// Always emit the vtable for an explicit instantiation definition
// of a polymorphic class template specialization. Otherwise, eagerly
// instantiate only constexpr virtual functions in preparation for their
use
@@ -2859,6 +2857,8 @@
/*ConstexprOnly*/ true);
}
+ Consumer.HandleTagDeclDefinition(Instantiation);
+
return Instantiation->isInvalidDecl();
}
Index: clang/lib/Sema/SemaTemplateInstantiate.cpp
===================================================================
--- clang/lib/Sema/SemaTemplateInstantiate.cpp
+++ clang/lib/Sema/SemaTemplateInstantiate.cpp
@@ -2846,8 +2846,6 @@
SavedContext.pop();
if (!Instantiation->isInvalidDecl()) {
- Consumer.HandleTagDeclDefinition(Instantiation);
-
// Always emit the vtable for an explicit instantiation definition
// of a polymorphic class template specialization. Otherwise, eagerly
// instantiate only constexpr virtual functions in preparation for their use
@@ -2859,6 +2857,8 @@
/*ConstexprOnly*/ true);
}
+ Consumer.HandleTagDeclDefinition(Instantiation);
+
return Instantiation->isInvalidDecl();
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
