MyDeveloperDay added a comment.
by and large, this looks pretty good to me..
================
Comment at: clang/docs/ClangFormatStyleOptions.rst:198
-**AlignConsecutiveAssignments** (``bool``)
+**AlignConsecutiveAssignments** (``AlignConsecutiveAssignmentsStyle``)
If ``true``, aligns consecutive assignments.
----------------
Did you regenerate this or make the changes by hand?
you need to run clang/tools/dump_style.py
================
Comment at: clang/include/clang/Format/Format.h:110
+
+ /// Styles for alignment of consecutive assignments
+ enum AlignConsecutiveAssignmentsStyle {
----------------
you need to provide full context diffs
https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface
================
Comment at: clang/lib/Format/WhitespaceManager.cpp:390
+ // Whether the current line consists purely of comments
+ bool LineIsComment = true;
----------------
add "." at the end
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93986/new/
https://reviews.llvm.org/D93986
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
