atirit added a comment.
From what I can tell the unit tests are broken. Take `FormatTest.ShortEnums`
for example. It passes the following code:
enum
{
A,
B,
C
} ShortEnum1, ShortEnum2;
And expects no changes to be made.
However, format unit tests use the `BreakBeforeBraces: Attach` option. This
option should attach braces to the same line, as demonstrated in the docs
<https://clang.llvm.org/docs/ClangFormatStyleOptions.html>:
> `BS_Attach` (in configuration: `Attach`) Always attach braces to surrounding
> context.
>
> namespace N {
> enum E {
> E1,
> E2,
> };
> // ...
> }
I'm new to this project so please correct me if I'm wrong, but this appears to
indicate broken tests. I'll push a commit with fixed tests.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93938/new/
https://reviews.llvm.org/D93938
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
