dmgreen added inline comments.
================ Comment at: llvm/include/llvm/Support/ARMTargetParser.def:306 +ARM_CPU_NAME("cortex-a78c", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, + ARM::AEK_RAS) ARM_CPU_NAME("cortex-x1", ARMV8_2A, FK_CRYPTO_NEON_FP_ARMV8, false, ---------------- RAS is already a part of ARMV8_2A. I think this should include ARM::AEK_FP16 | ARM::AEK_DOTPROD though, like the cortex-a78. ================ Comment at: llvm/lib/Target/AArch64/AArch64.td:700 + FeatureFMI, + FeatureFPARMv8, + FeatureFuseAES, ---------------- There are some missing here too from the above A78, like FeatureRCPC and FeatureSSBS (and DotProd) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93022/new/ https://reviews.llvm.org/D93022 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits