sammccall accepted this revision. sammccall added a comment. In D93452#2467046 <https://reviews.llvm.org/D93452#2467046>, @qchateau wrote:
> I did not use the CMke option as the default value for the command line > option: IMO this CMake option is only useful if you encounter build problems > related to malloc_trim, so malloc_trim must not be part of the code when you > disable it through CMake. This seems a bit too conservative to me, I wouldn't expect anyone to ever encounter such build problems (e.g. glibc so old that malloc_trim doesn't exist, or header exists but library doesn't), so I'd add a workaround if they actually arose. The other value of the CMake option is being able to disable the *default* behavior if you use another allocator, so that you don't have to ask all users to pass a custom flag. I don't feel strongly about this though, in the end it'll be the same thing for ~all users since the option is on by default. > If this all makes sense and I did not make a mistake in this update, you can > land this. Let me know if there are other small details you'd like me to > change. > > Email: quentin.chat...@gmail.com Thanks so much for working on this, it was both horrifying and a huge relief to see what you'd worked out here! I'll land now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93452/new/ https://reviews.llvm.org/D93452 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
