sammccall added a comment.
Thanks! Changes to ClangdServer are definitely good, I'm less sure about
renderTUAction.
================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1183
// are familiar by C++ programmers.
std::string renderTUAction(const PreambleAction PA, const ASTAction &AA) {
llvm::SmallVector<std::string, 2> Result;
----------------
Hmm, I'm not sure if this is more consistent or just different.
In vscode I think this currently renders as "clangd: running CallHierarchy",
and after this change it's "clangd: Running CallHierarchy". I'm not sure we
need a capital letter here?
================
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:1208
if (Result.empty())
return "idle";
+ return llvm::join(Result, ", ");
----------------
(if we do change this, this needs to be capitalized too)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93546/new/
https://reviews.llvm.org/D93546
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
