rsmith added a comment.

The implementation looks fine to me.

That said, I'm concerned that the design of this feature will severely limit 
its utility. For classes and enums, operators are typically defined in an 
associated namespace so that they can be found by ADL. For these types, there 
are no associated namespaces, so user-defined operators for them can never be 
found by ADL, and such operators are essentially never going to work in generic 
code. Maybe that's not something you care too much about for the intended use 
cases?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77056/new/

https://reviews.llvm.org/D77056

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D77056: [... Richard Sandiford via Phabricator via cfe-commits
    • [PATCH] D770... Eli Friedman via Phabricator via cfe-commits
    • [PATCH] D770... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D770... Richard Sandiford via Phabricator via cfe-commits
    • [PATCH] D770... Richard Sandiford via Phabricator via cfe-commits
    • [PATCH] D770... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D770... Richard Sandiford via Phabricator via cfe-commits

Reply via email to