sbaranga added inline comments.

================
Comment at: lib/Basic/Targets.cpp:4710
@@ -4709,1 +4709,3 @@
                  const std::vector<std::string> &FeaturesVec) const override {
+    if (CPU == "")
+      CPU = "generic";
----------------
rengolin wrote:
> This change is unrelated and may bring side effects into clang. I'd keep this 
> out and investigate it in another patch with the appropriate tests. If you 
> just force the target-feature in the test, this corner case won't be relevant 
> in this patch.
Ok, that makes sense. I'll revert to the previous revision of this patch.


http://reviews.llvm.org/D18963



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to