alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
================
Comment at: clang-tidy/misc/SuspiciousStringCompareCheck.cpp:215
@@ +214,3 @@
+ if (Result.Nodes.getNodeAs<Stmt>("suspicious-operator")) {
+ diag(Call->getLocStart(), "suspicious usage of function %0") << Decl;
+ }
----------------
Can you make the message more specific? It should make it clear, what exactly
is "suspicious" in this usage.
http://reviews.llvm.org/D19497
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
