aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM aside from some small nits, thank you for the fix! Do you need me to
commit on your behalf? (If so, are you okay with using `Emma Blink
<emmabl...@fb.com>` for patch attribution?)
================
Comment at:
clang-tools-extra/test/clang-tidy/checkers/readability-identifier-naming.cpp:619
+
+#pragma mark - Check implicit declarations in coroutines
+
----------------
================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:547
Context.getTrivialTypeSourceInfo(T, Loc),
SC_None);
+ VD->setImplicit(true);
CheckVariableDeclarationType(VD);
----------------
================
Comment at: clang/lib/Sema/SemaCoroutine.cpp:1581
S.Context.getTrivialTypeSourceInfo(GroType, Loc), SC_None);
+ GroDecl->setImplicit(true);
----------------
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D93402/new/
https://reviews.llvm.org/D93402
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
