rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

Looks good


================
Comment at: tools/driver/driver.cpp:350
@@ +349,3 @@
+  for (const char *F : argv) {
+    if (strcmp(F, "--rsp-quoting=posix") == 0)
+      RSPQuoting = POSIX;
----------------
Should we call it "posix" or "gnu"? The reference implementation we are trying 
to match is part of libiberty, which is why I called the tokenizer 
TokenizeGNUCommandLine.


http://reviews.llvm.org/D19425



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to