zaks.anna added a comment.
"Since we are adding support for so many new APIs that are only available on
Windows, could you please condition checking them only when we build for
Windows. You probably can look and Language Options to figure that out."
By this, I was suggesting that we should be conditionally checking for Windows
functions in the checker, not only the tests. Are these all of the
Windows-specific functions that will be added to the Malloc checker or do you
plan on adding more? If there are more variants, I definitely think we should
conditionally check (in the checker).
Regarding tests, they should reflect what is in the checker. Currently, the
checker will support '_mbsdup' on all architectures, but the tests only check
it on Windows.
================
Comment at: llvm/tools/clang/test/Analysis/malloc.c:1593
@@ -1511,3 +1592,3 @@
char *testLeakWithinReturn(char *str) {
return strdup(strdup(str)); // expected-warning{{leak}}
}
----------------
This is not Windows-only!
http://reviews.llvm.org/D18073
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
